Three things need fixes

• if an OpenID request is handled, comments.py, cmtExpr() breaks with None values

  
      if entry['absolute_path'] == None or entry['fn'] == None:
          return ''
  
  

• the database locking code in session.py, is broken; if the file does not exist, an exception is thrown

      def _lock(self):
          # ???: does this work as expected?
          try:
              if self._use_lock:
                  self._dbmfile_lock = open(self._dbmfile, "r+")
                  tools.lock(self._dbmfile_lock, tools.LOCK_EX)
                  self._locked = 1
          except:
                  pass
  
  
      def _unlock(self):
          # ???: does this work as expected?
          try:
              if self._use_lock and self._locked:
                 tools.unlock(self._dbmfile_lock)
                 self._dbmfile_lock.close()
                 self._locked = 0
          except:
                  pass
  
  

• in complete_openid_auth() of comments_openid.py version 0.4:

           # Ask the OpenID library to check the server's response
          response = consumer.complete(query, return_to)
  

  the second parameter, return_to, is required by python-openid version 2.1.1.

posted at: 23:56 | path: /projects/OpenID | permanent link

test stuff here

posted at: 15:35 | path: / | permanent link